Dev Meeting Transcripts (April, 2022)
[4:00 PM] kinkajou (SegWit Clique): Channel open
[4:03 PM] Tron: Thanks kinkajou (SegWit Clique) for opening the channel each week.
[4:05 PM] Tron: I'm still working on the 6 failing tests. It is related to the P2SH changes, and the IsStandardTx function. I can easily fix the tests to not error, but I want to understand the ramifications of IsStandardTx function failing before making changes.
[4:07 PM] Tron: 1 of the tests is failing as "dust", and the other with "scriptpubkey". It might be as simple as adding a type for P2SH, but that might also have knock-on effects to allow a transaction type that we shouldn't allow.
[4:08 PM] Tron: These are the tests that are failing:
[4:08 PM] Tron: feature_fee_estimation.py
feature_maxuploadtarget.py
mempool_limit.py
mining_prioritisetransaction.py
wallet_basic.py
rpc_addressindex.py
[4:13 PM] kinkajou (SegWit Clique): Same failures myself and ilaypipe got.
Can we look at merging 1184 to develop if it has been reviewed? https://github.com/RavenProject/Ravencoin/pull/1184#issuecomment-1076532365
It seems to be the source of a lot of issues on the testnet
[4:14 PM] kinkajou (SegWit Clique): There's also been some talk about adding kralverde 🤡 🇺🇸 as a core developer in ravenqt-sig-working perhaps he should have permissions?
[4:14 PM] Hans_Schmidt: FYI, I changed the way nonstandard txns work on testnet in PR#1048.
Previously, the chains rejected nonstandard transactions according to=> mainnet:true, testnet:false, regtest:false
The "-acceptnonstdtxn" CLI switch option was broken and had no effect.
After the PR, all chains default to rejecting nonstandard transactions, while allowing the "-acceptnonstdtxn" switch to change that behavior on testnet and regtest (but not mainnet).
[4:40 PM] LSJI07: One dev meeting starts and suddenly there is like a few new miners on testnet. Welcome! 😋
[4:42 PM] Tron: Merged 1184
[4:44 PM] Hans_Schmidt: Thanks!
[5:40 PM] kinkajou (SegWit Clique): I'll go ahead and close the channel then. Thanks everyone for coming!
————————————-
[4:00 PM] BadGuyTy: yay
[4:00 PM] kinkajou (SegWit Clique): Hello, channel should be open.
[4:01 PM] BadGuyTy: ok whats the stats of the bugs I want this release out the door so I can push through the mineable assets
[4:02 PM] BadGuyTy: How much C++ am I going to have to learn to get this done?
[4:03 PM] Someone_2: well there's also the hash header bug or whatever they're call it that was come across.
[4:03 PM] Someone_2: it was snagged/discovered on the testnet
[4:03 PM] BadGuyTy: I had to go dig through java earlier this week to find a stupid setting because the local devs couldn't be bothered to figure out the issue them selves
[4:04 PM] Someone_2: kind of a recap of last weeks meeting, Tron's invstigating why the python tests failed and wanted to investigate it further because it involves consensus code.
[4:06 PM] Tron: Quite a bit. Also a good understanding of the format of the coinbase, tranasactions, and the UTXO model. Also, some python to add functional tests.
[4:06 PM] LSJI07: Hi.
[4:07 PM] BadGuyTy: I got python down
[4:07 PM] Tron: Still working on the tests. Last week was very busy.
[4:07 PM] BadGuyTy: yeah I had to actually go into the office 😲 this week
[4:07 PM] Tron: The Blockchain Law Alliance site launched: https://roundtable.io/blockchain-law-alliance/
Blockchain Law Alliance
Blockchain Law Alliance
News and thoughtful analysis on blockchain regulations and their impact.
[4:08 PM] BadGuyTy: nice we need some sensible laws
[4:09 PM] Tron: We should be able to get it in front of a few US Senators (Lummis, and Lee at a minimum).
[4:10 PM] BadGuyTy: the other day Romney tried to tell me crypto was still a tool for criminals 🤦
[4:12 PM] kinkajou (SegWit Clique): Crypto is for everyone.
[4:12 PM] Tron: Point him to this site. It will help correct these types of misunderstandings.
[4:13 PM] Tron: Utah is in pretty good shape for crypto. There's already discussion of being able to pay for state services and taxes in crypto. It's some of the other states' Senators that need more education.
[4:13 PM] BadGuyTy: Anyways so to get this release out the door we need to figure out why those 6 python tests were failing
[4:14 PM] Tron: I'm on the Executive Board of the recently formed Utah Blockchain Coalition. https://www.utahblockchain.org/
piperhillconsulting
Home Page | www.utahblockchain.org
Utah Blockchain Coalition. A collective of industry partners and individuals working together to establish Utah as a leader in Blockchain and Cryptocurrency. About Utah Blockchain Coalition The Utah Blockchain Coalition is a collective of industry partners and individuals working together to est …
[4:15 PM] BadGuyTy: I'm not good at coding (non python languages) but finding bugs and digging through code I do well
[4:15 PM] Someone_2: any news on the header hash issue on testnet? I know people have been using the invalid and reconsier commands. I never got it to work, kept crapping out.
[4:16 PM] Someone_2: (maybe it's fixed and I don't know about it 🙂
[4:17 PM] kinkajou (SegWit Clique): Are you running Hans' 4.8 release?
[4:18 PM] Someone_2: I am not , no. Haven't tried synching anything testnet in at least a week.
[4:19 PM] Someone_2: I had orignially set out to try doing the DPI scaling test as I see it as something I can do without knowing how to code and it would be an item to finally knock off the list. Never got the testnet client to synch.
[4:21 PM] kinkajou (SegWit Clique): https://github.com/RavenProject/Ravencoin/issues/1188
Have you tried the
invalidateblock reconsiderblock
described here?
[4:22 PM] Tron: If anyone has node IP addresses for the testnet, could you put them here?
[4:22 PM] Someone_2: Yep tried the invalidate block and reconsider, it didn't work, tried it 4 times. I was not aware a new testnet client was out.
[4:23 PM] Someone_2: Kalverde quasi walked me through trying it.
[4:24 PM] kinkajou (SegWit Clique): Hans' new release can be found here: https://github.com/hans-schmidt/Ravencoin/releases/tag/v4.8.0test1
[4:25 PM] Someone_2: will give it a try 🙂
[4:39 PM] Hans_Schmidt: The 4.8 version does not contain a fix for the block #1127354 issue on testnet. In practice, a lot of people have been finding that 4.8 doesn't fail purely because it is statically linked, and they were previously using a client which they built themselves with dynamic linking (which appears to fail much more often). I spent some time looking at this issue, but it looks like a really flaky race condition. And testnet has been so inconsistently mined that it's often hard to tell which issues are specific to testnet. I ended up putting this on the back burner for a while.
[4:42 PM] Someone_2: I'll still try it out. Will see how it goes.
[4:43 PM] Hans_Schmidt: I just pick the best ones from here: https://rvnt.cryptoscope.io/network/
[4:56 PM] kinkajou (SegWit Clique): I will see if I can work out a long-term fix for the testnet mining issue this week then.
————————————-
[4:00 PM] kinkajou (SegWit Clique): Channel open
[4:06 PM] kinkajou (SegWit Clique): Tron any progress on those 6 failing tests?
[4:14 PM] Tron: Some. I recalled having the tests pass for p2sh and requesting another test or two for a failed multisig. I started with master and pulled in the original P2SH changes (commit 8c31e2b6c5668b6e59db0ed5375db1c1b017bedc) and the tests pass. Somewhere along the way, the test broke. Next step — find out where/when.
————————————-
[4:00 PM] kinkajou (SegWit Clique): 👋
[4:17 PM] Sevvy ♾ (werebear): Heya
[4:17 PM] LSJI07: Hi
[4:17 PM] Steelers: 👋
[4:18 PM] Hans_Schmidt: Yo
[4:20 PM] LSJI07: What's the priority at the moment? Anything we can help with?
[4:21 PM] Hans_Schmidt: Testing on testnet
I spent a half-day this week back-and-forth with BF diagnosing and developing a patch for the Testnet Block #1127354 Sync Hang Bug
We believe that this fixes the bug. But the intermittent nature of the bug makes additional testing necessary.
Pre-compiled binaries including this PR for use on testnet testing are available at
https://github.com/hans-schmidt/Ravencoin/releases/tag/v4.8.5test1
The bug is related to the use of SubQualifiers for Restricted Assets and exists in all previous versions of core which support Restricted Assets. Since it is a failure in reading cache properly, it does not occur once the cache flushes to database, making it dependent on node speed, compile types, and other things which affect timing.
[5:55 PM] kralverde 🤡 🇺🇸: I'll move my mining node over
————————————-
[4:00 PM] kinkajou (SegWit Clique): Channel open
[4:03 PM] kinkajou (SegWit Clique): Tron any more progress made on those failing tests?
[4:04 PM] Tron: I haven't had much time. I have found one specific PR that adds 3 failures — so narrowing it down.
[4:04 PM] Tron: Sorry I missed last week's dev meeting. I was speaking at the Utah Bitcoin Conference.
[4:05 PM] kinkajou (SegWit Clique): Which PR is it?
[4:09 PM] Tron: 8c31e2b6c5668b6e59db0ed5375db1c1b017bedc
[4:10 PM] Tron: feature_assets_p2sh.py | ✖ Failed | 2 s
[4:11 PM] Tron: Second test run only gave 2 failures. 1 of the failures may have been a connection failure.
[4:13 PM] Tron: Has anyone experienced sync failures using: Pre-compiled binaries including this PR for use on testnet testing are available at
https://github.com/hans-schmidt/Ravencoin/releases/tag/v4.8.5test1 ?
[4:15 PM] Someone_2: I had been specifically having synch problems repeatedly. The one at the above link seems to have fixed it. Synched no problem at all on the firs try.
[4:16 PM] kinkajou (SegWit Clique): I'll test that release Monday but I wasn't having sync issues with the previous 2 releases. Core Tester did any of you get a chance to look at it this week?
[4:23 PM] LSJI07: I haven't tested that.
[4:28 PM] LSJI07: Downloaded and syncing now.
[4:30 PM] LSJI07: Partial syncing now. After that will try a full sync.
[4:40 PM] LSJI07: the last 3 weeks is taking a while. 10 nodes connected, zero banned.
[4:59 PM] Mango Farm: No sync issues with 4.8.5 on my end but have had unexplained crashes on windows when solo mining testnet for multiple versions. Can’t say what the cause is. The miner continues to run so it is on the Raven side but the log reports only show GUI errors.
[5:03 PM] LSJI07: Are you still getting crashes on 4.8.5 specifically? I understood that had a fix for mining rapid blocks in succession.
[5:05 PM] Mango Farm: Yes. At startup 4.8.5 will mine a ton of blocks quickly until the difficulty adjusts but after about a day I’ll notice it is shut down (with the miner and windows still running). The log shows gui errors but that’s it. I have it up now so will drop the log when it replicates again.
[5:08 PM] LSJI07: my node is claiming the partial sync will finish in 10 mins. ill redo a full sync after the partial finishes.
[5:09 PM] Hans_Schmidt: The mining bug which we fixed did not crash core. It locked up core in a continuous loop which you couldn't get out of without killing core. But it required a VERY specific set of circumstances.
[5:11 PM] Mango Farm:
Image
[5:13 PM] Mango Farm: There’s the last log before a crash but I wasn’t very methodical about being certain that was the last thing. I’ll keep an eye on it and wait for a crash. Then post with more certainty. It’s not a 4.8.5 issue it has been happening for a while. I thought it was windows sleeping but this last go I learned that was not it.
[5:14 PM] Hans_Schmidt: Never seen that one before. You say multiple versions? Do you know if that includes v4.3.2.1 or only newer versions?
[5:15 PM] Mango Farm: Only post 4.3.2.1. And only windows. I have post 4.3.2.1 testnet linux nodes running without issue.
[5:16 PM] Mango Farm: I’ll see if I can narrow this down and produce a log I’m sure immediately preceded the crash next time it does it. Mind you I’m solo mining on this node so that could be a unique factor at play.
[5:18 PM] Hans_Schmidt: Which miner are you using (so I can try to duplicate)? TTMiner?
[5:18 PM] Mango Farm: Tt
[5:19 PM] Mango Farm: Windows 10 home is the OS
[5:20 PM] Hans_Schmidt: With all those GUI errors and Windows only, it might be QT related since we did a lot of QT upgrade work since v4.3.2.1. The QT in v4.3.2.1 was dangerously old. The upgrade fixed multiple QT security issues, but a number of projects have reported other new bugs.
[5:24 PM] LSJI07: Partial sync completed fine on 4.8.5test1. Doing the full sync now.
[5:25 PM] LSJI07: Only 3 years and 31 weeks to go.
[5:25 PM] Mango Farm: I tested the sync on 4.8.5 several times and it worked like a charm
[5:28 PM] Hans_Schmidt: v4.8.5test1 seems to have fixed the SubQualifier sync hang bug for me too. I think we killed that bug.

submitted by /u/Blockchain_Surfer
[link] [comments]