Dev Meeting Transcript (February 11, 2022)

[4:05 PM] BadGuyTy: Almost forgot again!

[4:05 PM] LSJI07 – BWS: I have made a brief list of items for today. Very brief unless someone has a longer agenda. 🙂

[4:05 PM] LSJI07 – BWS: 1. Update on the Ledger progress for rvn asset support. Is anything needed from the community to help progress.

1. Progress on p2sh and next wallet release.

[4:07 PM] kralverde 🤡 🇺🇸: Ledger is going slow but sure

[4:08 PM] BadGuyTy: My question on the next release is if its not coming soon can we maybe squeeze in mineable assets? Not sure how much more work that would be though

[4:08 PM] BadGuyTy: I would like to see those definitly before eth goes pos

[4:08 PM] kralverde 🤡 🇺🇸: https://github.com/kralverde/app-ravencoin here is the repo for ledger

[4:09 PM] kralverde 🤡 🇺🇸: Everything works but its unstable; crashes sometimes, finding out why

[4:09 PM] LSJI07 – BWS: Mineable assets would be a concensus change and bad practice imo to include more that one significant change in a release. P2SH is enough for the next release imo.

[4:09 PM] kralverde 🤡 🇺🇸: https://discord.com/channels/429127343165145089/819274815696797717/856684438254911529 and here is how to emulate

[4:09 PM] kralverde 🤡 🇺🇸: And if anyone wants to help feel free, written in c

[4:11 PM] BadGuyTy: sorry I got enough things I'm trying to do like make a pgp tag faucet and api for squawker

[4:12 PM] LSJI07 – BWS: I got given a ledger recently so can help test but not programming. I know my limits at the moment.

[4:14 PM] LSJI07 – BWS: Will make a community request though on as many channels as possible for devs to assist. Don't ask, don't get. 🙂

[4:15 PM] Tron: I'm back home. I'll set some time aside next week to review PRs for inclusion.

[4:18 PM] LSJI07 – BWS: Thats awesome. Thank you! I saw quite a few small prs moving on github recently.

[4:18 PM] Hans_Schmidt: Most of the PRs have already been merged into develop. There are just a few more. And some cleanup.

[4:20 PM] BadGuyTy: I'm excited to add to the rvn dev movie! I need a cleaner way of including the btc code forks though those make the image jump all over the place.

[4:20 PM] Hans_Schmidt: Also, there is one more bug fix which I want to include in the next release. In December we had a report of a nasty bug in core which caused all the pool operators to lock up at the same time and require restarting. It was caused by a case in which miners were lucky enough to find two blocks less than one second apart. I'm in the process of writing up the PR bug fix for that.

[4:21 PM] BadGuyTy: my question is how did the miners know the question that fast to find the answer that fast

[4:22 PM] Someone_2: I remember reading about that. Somehow 3 blocks were found inside of like 40 seconds of eachother and it did really bad things.

[4:22 PM] BadGuyTy: I remember it happening for sure

[4:23 PM] LSJI07 – BWS: pure chance imo. good to have a fix in the works. surprised testnet didnt have that bug though. found lots of blocks close together there.

[4:24 PM] BadGuyTy: yeah but on test net your not fighting with others for consensus

[4:25 PM] Hans_Schmidt: Testnet has had some other issues which look like they may be related, but it's hard to tell for sure since it's difficult to reproduce and the error messages are not very helpful.

[4:27 PM] BadGuyTy: good error messages are impossible

[4:27 PM] Hans_Schmidt: Plus the two blocks have to be REALLY close together.

[4:28 PM] BadGuyTy: sub second is highly unlikely. lets say 0.2 latency total thats 0.8 for a solution which is not long

[4:31 PM] Someone_2: despite 'close' being relative. If I remember correctly, it was roughly that 3 blocks were found in under a minute(totally screwing up the average) and then nothing was found for like 10 minutes, perhaps evening out what had just happened, and it was wondered briefly if the chain had crashed.

[4:33 PM] LSJI07 – BWS: is anyone monitoring chain tips? and the longest fork?

[4:33 PM] LSJI07 – BWS: recently?

[4:34 PM] Tron: No, but near the halving the chain for NiceHash was out-of-sync. Possible attempt at 51% attack.

[4:35 PM] LSJI07 – BWS: I personally haven't seen any significant splits longer that 10 blocks, normally hovering around 1 or 2 max.

[4:35 PM] BadGuyTy: I can't wait till the usage gets up there that that sort of thing is impossible.

[4:36 PM] LSJI07 – BWS: But that is very casual monitoring and not an in depth review. 🤣

[4:39 PM] LSJI07 – BWS: Wrapping a stability fix Hans mentioned and the P2SH code sounds fine imo as long as only one is consensus related.

[4:40 PM] BadGuyTy: So what are we thinking the new release date should be around?

[4:40 PM] LSJI07 – BWS: Preaching to the choir. I'll sit down.

[4:41 PM] BadGuyTy: assuming everything is approved and merged into dev what would we be looking at for a date?

[4:44 PM] Hans_Schmidt: They are both in consensus code but the bug fix is two lines of code.

[4:46 PM] Hans_Schmidt: Timing depends on multiple people to approve so it's not under any one person's control.

[4:50 PM] LSJI07 – BWS: Ok, I thought they could be. So double checking. Can we do 2 releases? 1 with the stability fix only (no BIP9) and one immediately after with P2SH (with BIP9)? That way people have the choice. I know its a PITA but its fairer to ensure P2SH consensus is clear. I dont believe a BIP9 is required for the stability consensus issue (tell me if I'm wrong here).

[4:53 PM] LSJI07 – BWS: The second release contains the stability fix plus P2SH (BIP-9) for clarity.

[4:54 PM] Hans_Schmidt: It can be one release with only the P2SH stuff wrapped up in the BIP9 miner approval.

[4:55 PM] LSJI07 – BWS: I like simple.

[4:58 PM] Hans_Schmidt: There are quite a few PRs that will be in the release which touch consensus code, but are not expected to have any effect on on-chain consensus. The <1sec block bug fix, for instance, is in the consensus section of code but shouldn't change what goes on the chain. The pools didn't put anything weird on the chain, they just looked up.

[4:59 PM] Hans_Schmidt: Most of those are code fixes ported from bitcoin.

[5:04 PM] LSJI07 – BWS: Thanks for the info and updates. Appreciate it. Thank you all for coming! :rvn_heart_2:

[5:04 PM] LSJI07 – BWS: I'm doing a runner.

[5:06 PM] Hans_Schmidt: The P2SH for assets feature needs BIP9 approval because it's a major feature change and also a massive amount of new code which affects consensus.

[5:42 PM] kinkajou (SegWit Clique): I'll go ahead and wrap this one up. Any further discussion can continue in development

Thanks for coming, everyone