Wallets?

I am curious as to whether i should continue using my current wallet or get set up with something new. I use the BRD app to hold my crypto(mostly ethereum and a little btc and xrp). I dont buy directly through the app or on any website all my transactions are done using cash at an atm. What wallets are you guys using? Are your wallets on your phone or on your cpu? Any advice or constructive criticism is much appreciated. I have been investing in crypto for almost a year now and am at the point where i need to start taking security of my investments seriously.