Dev Meeting Transcript (December 10, 2021)

[3:51 PM] kralverde 🇺🇸 {CULT OF JOE}: Channel is open

[3:58 PM] kralverde 🇺🇸 {CULT OF JOE}: Can confirm the latest dev branch builds on arm7l

[4:02 PM] Tron: I have invited folks from Twitter to help test. Could you post a link to information on testing?

[4:03 PM] kinkajou (SegWit Clique): https://github.com/fdoving/RavenStash/blob/main/testing-4.7.0test.md

[4:04 PM] Tron: Thank you.

[4:08 PM] kralverde 🇺🇸 {CULT OF JOE}: was it LSJI07 – BWS who had the testing online meetup?

[4:08 PM] kinkajou (SegWit Clique): Yes, only two of us attended though sadly

[4:08 PM] kralverde 🇺🇸 {CULT OF JOE}: As I understand we need to look at restricted assets for p2sh and watch only addresses with assets

[4:09 PM] kinkajou (SegWit Clique): And I of course didn't have a mic so poor LSJ just talking to himself 😅

[4:09 PM] kinkajou (SegWit Clique): Yes I experienced issues specifically with tagging P2SH addresses and sending the associated restricted asset.

[4:09 PM] Sevvy //: I borked my testnet instance on my windows machine trying to transplant my chainstate data to an ubuntu rig

[4:09 PM] Sevvy //: 😔

[4:10 PM] kinkajou (SegWit Clique): Was not able to get 'Watch only' in the GUI for P2SH or P2PKH Asset Balances though RVN balances display correctly

[4:10 PM] Sevvy //: I was the one who kind of compelled LSJ to even schedule the testing session

[4:12 PM] kinkajou (SegWit Clique): Also AFAIK none of us have successfully sent assets from a P2SH address yet either. More GUI support would be nice.

[4:13 PM] Sevvy //: yeah

[4:13 PM] kralverde 🇺🇸 {CULT OF JOE}: at least the basic unlocking script right?

[4:13 PM] kinkajou (SegWit Clique): LSJI07 – BWS opened a dedicated issue and bounty for that here: https://github.com/RavenProject/Ravencoin/issues/1142

[4:14 PM] kralverde 🇺🇸 {CULT OF JOE}: for multisig or p2sh?

[4:14 PM] kinkajou (SegWit Clique): multisig is p2sh

[4:15 PM] kralverde 🇺🇸 {CULT OF JOE}: its an application of p2sh

[4:16 PM] kralverde 🇺🇸 {CULT OF JOE}: p2sh is kind of similar to a smart contract….

[4:16 PM] kralverde 🇺🇸 {CULT OF JOE}: kinda

[4:16 PM] kralverde 🇺🇸 {CULT OF JOE}: not really

[4:16 PM] kralverde 🇺🇸 {CULT OF JOE}: its just a more options locking script

[4:16 PM] kinkajou (SegWit Clique): the issue is specific to GUI support for multisig p2sh

[4:16 PM] kralverde 🇺🇸 {CULT OF JOE}: Yeah

[4:16 PM] kralverde 🇺🇸 {CULT OF JOE}: I added it to my list 😎

[4:16 PM] Sevvy //: neat

[4:16 PM] kralverde 🇺🇸 {CULT OF JOE}: of stuff to do on holiday

[4:17 PM] kinkajou (SegWit Clique): multisig is the p2sh application I have been testing as well

[4:17 PM] kralverde 🇺🇸 {CULT OF JOE}: cool beans

[4:19 PM] kinkajou (SegWit Clique): https://github.com/RavenProject/Ravencoin/issues/990#issuecomment-989151364 is particularly deserving of attention though, IMO. I would expect restricted assets to be one of the more common applications for multisig p2sh so ensuring it works properly is crucial.

[4:19 PM] Sevvy //: agreed

[4:20 PM] kralverde 🇺🇸 {CULT OF JOE}: yeah, right now we just gotta try to break stuff in the testnet and add issues on gh

[4:23 PM] Hans_Schmidt: It can be confusing because there is a CHECKMULTISIG opcode which can be used on RVN just as on BTC to do "standard" multisig. But it's limited to 3 signatures and it results in a large transaction, so most multisigs are actually done using P2SH.

[4:25 PM] Sevvy //: hmmm, didn't know that

[4:29 PM] Hans_Schmidt: I want to acknowledge that there have been a few other small bugs which have been reported in the channels not related to P2SH. It takes time to reproduce, diagnose, and fix these things. But they will eventually be resolved, so it's worth thanking those people who put effort into reporting them and opening github issues when possible.

[4:31 PM] LSJI07 – BWS: the struggle has been the only way to spend from a multisig is via createrawtransaction and very few understand it imo to write a guide on how to do it WITH assets. ill have a go but its gonna take awhile.

[4:34 PM] LSJI07 – BWS: using the gui with a multisig address in the wallet and all the private keys it works to send assets. we tried issuing all the asset types into a multisig address and the sending from that address using the gui. That is obviously not how its meant to be used so kinda irrelevant other than its worth noting as interesting on the positive side.

[4:37 PM] kinkajou (SegWit Clique): This is actually not working for me

[4:37 PM] LSJI07 – BWS: just tags though correct?

[4:37 PM] kinkajou (SegWit Clique): When trying to send out from a multisig address and I select the asset on the dropdown menu it disappears immediately after being selected.

[4:38 PM] Jeroz: I saw the tweet. Do all points at https://github.com/fdoving/RavenStash/blob/main/testing-4.7.0test.md need testing on MacOS? Or only specific ones? "Test OSX binaries on various versions of OSX" is rather vague and broad.

[4:38 PM] kinkajou (SegWit Clique): Nope seems to apply to main assets as well at least when using the GUI. I'm specifically talking about sending an asset FROM a multisig address.

[4:38 PM] Sevvy //: holy shrimp Jeroz is here 🦐

[4:39 PM] kralverde 🇺🇸 {CULT OF JOE}: eyy jeroz is back

[4:39 PM] kralverde 🇺🇸 {CULT OF JOE}: afaik little testing has been done on mac/osx in general

[4:39 PM] Someone_2: I just noticed his pic.

[4:40 PM] kinkajou (SegWit Clique): I think it'd be prudent to test all of the new features on each OS at least once to ensure they work.

[4:40 PM] kralverde 🇺🇸 {CULT OF JOE}: that would suck

[4:40 PM] Jeroz: I have Bug Sur (11.6) and Mojave (10.14) in a virtual box.

[4:41 PM] kralverde 🇺🇸 {CULT OF JOE}: fdov do you know what needs to be done with respect to MacOS/OSX?

[4:41 PM] Tron: These tests should show how to use p2sh and multisig for assets. https://github.com/RavenProject/Ravencoin/blob/develop/test/functional/feature_assets_p2sh.py

[4:41 PM] kinkajou (SegWit Clique): I've just tested this again during the meeting and it's working now lol LSJI07 – BWS

[4:42 PM] LSJI07 – BWS: i was firing up my testnet node to double check!

[4:42 PM] kinkajou (SegWit Clique): Yeah I tried it before posting that and got the error described but now its working.

[4:46 PM] LSJI07 – BWS: i had a few anomalies I will detail as separate issues. on creating qualifiers and sub qualifiers that the gui was different for the various asset types. just to keep them to the same process. the # was required for creating qualifier types of assets however the prefix was not required for the rest of the asset types. It was already automated in them i think.

[4:46 PM] RAVENCOIN.TIMELINE.OVH: I can do some testing on OSX latest version

[4:47 PM] kinkajou (SegWit Clique): Right. Might be because restricted assets share the same name as the main asset theyre associated with whereas qualifier strings can have unique names

[4:48 PM] kinkajou (SegWit Clique): But having that # added to the prefix initially would help to prevent some user confusion IMO. It got me the first time as well

[4:51 PM] Hans_Schmidt: I have noticed similar oddities on occasion. The implementation is not consistent nor the same as the documentation.

[4:55 PM] Tron: These are issues related to the speed of development at the time. They can be fixed, but we should publish some notes for any changes that are not backwards compatible, or could break existing RPC calls.

[4:57 PM] Tron: Also the lesser used features (tagging, etc) didn't get as much user testing.

[5:09 PM] LSJI07 – BWS: I see the test and see familiar console commands etc but its python and not english. Creating the multi sig is doable in console. Spending is ahem fun for me at the moment… Ill have a go at using it though in console and report back if i get seriously stuck and create something a bit more user friendly. 🙂

[5:12 PM] LSJI07 – BWS: On a side note the new gui screen for wallet creation are much better. I recently installed an atomic dex komodo wallet and a good feature they had was forcing the user to select a specific random seed word (or two) to ensure the user had recorded it correctly before letting them through…seems good practice for a future improvement perhaps.

[5:13 PM] kinkajou (SegWit Clique): exodus wallet does this too. I agree it encourages safe habits. no harm in creating an issue in case someone wants to pick it up